Quantile function #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added the quantile function for the purpose of determining the natural marginals of the Archimedean copulas.
I added a test with the unknown distribution, in this case the calculated quantile is expected to be equal to the quantile of the Earlang distribution
|
The end that was there before is the end of the module : it needs to be at the end of the file otherwise your functions will never be loaded. Move it at the end and you'll see that the tests run much better ! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6 +/- ##
==========================================
+ Coverage 81.25% 82.85% +1.60%
==========================================
Files 1 1
Lines 32 35 +3
==========================================
+ Hits 26 29 +3
Misses 6 6 ☔ View full report in Codecov by Sentry. |
|
Looks good to me. I'll merge this and publish a new version tomorrow morning. Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I added the quantile function and a test. All with the purpose of calculating the marginals of the radial distributions of the Archimedean copulas